Skip to content

8342074: Fix runtime/Thread/TestAlwaysPreTouchStacks.java to be flagless or accept VM flags #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

8342074: Fix runtime/Thread/TestAlwaysPreTouchStacks.java to be flagless or accept VM flags #2088

wants to merge 1 commit into from
+1 −1

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Aug 13, 2025 •
edited by openjdk bot
Loading

I backport this for parity with 21.0.9-oracle

Resolved due to context, maybe clean.

... it is not clean because the indentation differs besides different code in the 2./3. line in the context after the change.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8342074 needs maintainer approval

Issue

  • JDK-8342074: Fix runtime/Thread/TestAlwaysPreTouchStacks.java to be flagless or accept VM flags (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2088/head:pull/2088
$ git checkout pull/2088

Update a local copy of the PR:
$ git checkout pull/2088
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2088/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2088

View PR using the GUI difftool:
$ git pr show -t 2088

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2088.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 13, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 13, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title backport 9291abc6337f8cf480806f4b2996ec905b021704 8342074: Fix runtime/Thread/TestAlwaysPreTouchStacks.java to be flagless or accept VM flags Aug 13, 2025
@openjdk
Copy link

openjdk bot commented Aug 13, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Aug 13, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 13, 2025 •
edited
Loading

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Aug 14, 2025

GHA failure
Test SOEDeeplyNestedBlocksTest.java gets stack overflow.
We actually see this also in our CI, only on mac x86_64. The test is new in 21.
Our CI does not show problems in higher releases that also run the test.

But this is unrelated to this backport.

@GoeLin GoeLin force-pushed the goetz_backport_8342074 branch from 2ba6256 to a46b1d5 Compare August 14, 2025 07:58
@openjdk
Copy link

openjdk bot commented Aug 14, 2025

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport Port of a pull request already in a different code base rfr Pull request is ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GoeLin